Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jolestar
Copy link
Contributor

@jolestar jolestar commented Mar 2, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Implement Math::sqrt_u256

Issue Number: N/A

What is the new behavior?

Other information

TODO add more test

@jolestar jolestar requested review from WGB5445 and nanne007 March 2, 2022 09:12
Copy link
Contributor

@WGB5445 WGB5445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WGB5445 WGB5445 merged commit 4c81e55 into main Mar 7, 2022
@jolestar jolestar deleted the sqrt_u256 branch March 7, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants