Fix gpd UserWarning when plotting with color & column params #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
==========================================
+ Coverage 95.94% 96.38% +0.43%
==========================================
Files 34 35 +1
Lines 4239 4256 +17
==========================================
+ Hits 4067 4102 +35
+ Misses 172 154 -18 ☔ View full report in Codecov by Sentry. |
anitagraser
reviewed
Dec 14, 2024
movingpandas/trajectory_plotter.py
Outdated
| color=line_gdf["color"], | ||
| *self.args, | ||
| **{ | ||
| x: self.kwargs[x] for x in self.kwargs if x != "column" |
There was a problem hiding this comment.
I think self.kwargs.pop("column") would be more readable
|
Hi @anitagraser - I was hesitant to modify the original kwargs dict at first but I think it should be fine (and yes definitely easier to read). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #438