This repository was archived by the owner on Nov 18, 2024. It is now read-only.
Render saved comments in Browse mode - #1102
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1102 +/- ##
=========================================
Coverage ? 98.02%
=========================================
Files ? 59
Lines ? 2030
Branches ? 519
=========================================
Hits ? 1990
Misses ? 30
Partials ? 10
Continue to review full report at Codecov.
|
Contributor
Author
|
@willdurand not a rush but if you have some time to look, I'd like to get this in the tag tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #713
The
CommentListcomponent gets rendered for every single line in a file. If that line doesn't have comments, it rendersnull.CommentListwill lazily dispatch a loader (a thunk) once. I think performance-wise it's fine because nothing gets dispatched until the thunk starts running and the thunk returns early in case a load is in progress.I chose to put the loader here only because this is the component that depends on comments. In the future, more components might depend on loaded comments so we could move it to a shared
<WithLoadedComments>provider or something.