Add Navbar actions to summarize all comments - #1170
Conversation
bobsilverberg
left a comment
There was a problem hiding this comment.
This is really nice, and I love how little code it takes to make this change to the Navbar!
r+wc
| )} | ||
| <div className={styles.info}> | ||
| {currentVersion && ( | ||
| <div className={styles.infoItem}> |
There was a problem hiding this comment.
I notice in the test that you used to check for the text of .${styles.addonName}, which would only include the add-on's name, but now you're checking for the text of .${styles.info} which could include more than the name. I know you're controlling that in the test by making sure there aren't also some comments, but do you think there is any value in still assigning a unique className to this div? I'm not sure there is, but figured I'd raise it.
There was a problem hiding this comment.
I try to avoid adding class names purely for testing so that's my one hesitation. If we ever show the comments navbar for zero or undefined comments then this test would break but we could cross this bridge when we come to it.
Heh, well, there were a lot of patches leading up to it. Thanks for the quick review. |
I didn't mean to imply that you didn't do a ton of work leading up to this - I know that's why the patch was so small. I was trying to compliment you on that fact. 👍 |
|
Oh, I know. I was just trying to say that it wasn't a small patch, unfortunately! React / Redux requires a lot of code and that's something I've been thinking about lately. |
Fixes #114
Notes
Example screenshots