test that one can mutate managed Rkv instances in surprising ways#129
Merged
ncloudioj merged 1 commit intomozilla:masterfrom Sep 11, 2019
Merged
test that one can mutate managed Rkv instances in surprising ways#129ncloudioj merged 1 commit intomozilla:masterfrom
ncloudioj merged 1 commit intomozilla:masterfrom
Conversation
Contributor
|
Can we land this? @ncloudioj |
Member
|
I think so, I will check it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because Manager stores Rkv instances as Arc<RwLock>, and RwLock has interior mutability, it's possible to replace a managed Rkv instance, resulting in surprising behavior when retrieving instances from the Manager.
This branch just demonstrates the surprising behavior of Manager when one of its mapped Rkv instances is replaced by a new instance.