WebGPURenderer: Decouple samplers from textures. #31899
Open
+150
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #31886.
Description
The PR makes sure sampler data (that includes
minFilter,magFilter,wrapS/T/R,anisotropyandcompareFunction) can be changed after the initial use of the texture like inWebGLRenderer. InWebGPURenderer, that did work for the WebGL backend but not for the WebGPU one so far.To implement this, the PR decouples the sampler management from textures. Previously, samplers were created per texture which is not the way they should be used in WebGPU. Samplers can be shared across different textures if their configuration matches. The related caching/creation management is implemented in
WebGPUTextureUtils.