Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@maver1ck
Copy link
Contributor

@maver1ck maver1ck commented Nov 4, 2025

Summary

  • derive child workflow task queue from the Serverless Workflow namespace field
  • remove redundant child namespace overrides so all examples inherit the parent queue unless explicitly changed

Testing

  • go test ./...

@maver1ck maver1ck changed the title chore: align example child workflow namespaces chore: align example namespaces with task queues Nov 4, 2025
@maver1ck maver1ck changed the title chore: align example namespaces with task queues chore: align namespaces with task queues Nov 4, 2025
@maver1ck maver1ck changed the title chore: align namespaces with task queues feat: align namespaces with task queues Nov 4, 2025
@mrsimonemms mrsimonemms force-pushed the namespace-child-alignment branch 2 times, most recently from 0d9e775 to 7ac7617 Compare November 13, 2025 08:05
@mrsimonemms
Copy link
Owner

I love the idea of this, but namespace on the run.workflow is a required field by the Serverless Workflow spec. When you run the child workflow example (easiest way is air inside the /examples/child-workflows directory), it fails validation.

One of the goals of the v0.1 (pre-release) version of this project is to maintain compatibility with the Serverless Workflow spec, so I don't think this should go in in this form.

@mrsimonemms mrsimonemms self-requested a review November 13, 2025 08:27
@maver1ck
Copy link
Contributor Author

I love the idea of this, but namespace on the run.workflow is a required field by the Serverless Workflow spec. When you run the child workflow example (easiest way is air inside the /examples/child-workflows directory), it fails validation.

One of the goals of the v0.1 (pre-release) version of this project is to maintain compatibility with the Serverless Workflow spec, so I don't think this should go in in this form.

But I think your implementation is using top level namespace as Temporal queue name.
So this PR is in line with current implementation.
Ref: https://github.com/mrsimonemms/temporal-dsl/blob/facb123abecf6e5ee67575c424265970b2866c83/pkg/dsl/schedules.go#L64

@mrsimonemms
Copy link
Owner

Yes, it allows for the Serverless Workflow's namespace to be aligned to the Temporal task queue, but it still doesn't solve the problem of the Temporal DSL binary to run - when I try it, it errored with a validation error.

Based on what I think you were trying to do, I created #106. This introduces the concept of PostLoad hooks. After the YAML is loaded, it allows for arbitrary changes to the given workflow.

I'd still like to hang fire on the default task queue on the run.worker for the moment, especially as the task doesn't actually have the namespace wired up to anything. I'd love the Python example though, if you can make the change so that workflow.yaml is like the Basic/TypeScript examples.

@maver1ck maver1ck force-pushed the namespace-child-alignment branch from 7ac7617 to 262cdad Compare November 18, 2025 19:27
@maver1ck
Copy link
Contributor Author

maver1ck commented Nov 18, 2025

Hi @mrsimonemms
Could you check current version ? I just re-add namespaces in child-workflow but with correct values.
TL;DR; that's my proposition how mapping to task queues should look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants