Create CreateDBFromPSH #107
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates database from source code using Powershell for use in built agent
|
I like this, is the intent to provide this along with the code so users only need to use this PS file to basically "build" a new version? I've made some comments; I like the idea behind this, and the impetus, my only concern is that if users try to do this, they will end up with a forked upstream that may or may not like being updated with additional upstream updates (an issue I encountered with mine). |
hecon5
requested changes
Feb 15, 2021
| # It creates a new Access database, then loads VCS Loader in the database. Afterwards it loads the framework and imports the project from source repository. | ||
| # This script can be used in a build server with Access installed on it. | ||
| # Comment line 90 from VCS_Loader.bas 'MsgBox "Form Version: " & FormsVersion & " loaded" | ||
| # Change VCS_ImportExport.bas: |
There was a problem hiding this comment.
If the intent is to provide a "ready to use" deployment tool, I would ask that you make these changes, and build some logic to allow non-users of this PS to continue life as normal and use these changes where this PS is being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates database from source code using Powershell for use in built agent