Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Merge back the updates previously made #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 60 commits into from
Closed

Merge back the updates previously made #87

wants to merge 60 commits into from

Conversation

hangie
Copy link

@hangie hangie commented Mar 21, 2019

Hi,

Sorry for the long absence. I had been caught up and couldn't check the changes. I've now merged with the latest master and replaced (mostly alternative) the previous UI implementation with a more complete version that supports all components.
I've also added INI file for configuration.
Fixed a number of bugs (I'll have to go through them later and cross ref them).
Added the XML export of data to fix some bugs.
Export queries as .sql when exporting as SQL and as .bas when not.
Have a look. Pretty sure this is good to go.

Cheers,
Mark.

hangie added 30 commits March 17, 2018 10:28
@hangie
Merge pull request #1 from timabell/master
525e2c8 
Updates from master repo
@hangie
Force CRLF line endings as repository has majority this way
0c160a0
@hangie
Fix msaccess-vcs-integration#66
e144a95
@hangie
Move to using XML for tabledefs and tabledata
01a1c34
@hangie
Add newline to end of files and round trip import/export of VCS modules
6e2c5ba
@hangie
Fix issue with export of relationships and fix previous error with ex…
8eed85a 
…tra newline
@hangie
Fix import/export of the demo database
7113f23
@hangie
Merge pull request #2 from hangie/feature/use_xml_export
69e7629 
Feature/use xml export
@hangie
Add ini file handler
0b6b4cb
@hangie
Remove useless symlink
c9ec1d0
@hangie
Add ini handler on import
1a4df3f
@hangie
Merge pull request #3 from hangie/feature/ini_handler
5c908ce 
Feature/ini handler
@hangie
Fix line endings.
11786f8
@hangie
Add VCS menus
81022fb
@hangie
Merge branch 'master' into tmp_master
429d616
@hangie
Merge with latest and also added menu stuff as part of merge
edf60e7
@hangie
Add ini file handler
110b511
@hangie
Remove useless symlink
63aa75a
@hangie
Add ini handler on import
1f19dae
@hangie
Fix loading of customisations
818eddf
@hangie
Fix load error and missing forms defaults
ed9f573
@hangie
Remove custom menu if it exists
d37f78c
@hangie
Don't export empty table data
6c1c081
@hangie
Merge branch 'feature/vcs_menus' into dev/vcs_menus
b9c76e0
@hangie
Fix merge issue
1c8025d
@hangie
Add delete of query to other if condition
647993c
@hangie
Fix merge issue for Tables
5eeeac7
@hangie
Update exported version of demo database
da5f271
@hangie
Merge pull request #5 from hangie/dev/vcs_menus
bb8e340 
Dev/vcs menus
@hangie
Add export of table attributes to support saving defaults. Regen demo…
d4b4c5b 
… output
hangie added 16 commits March 21, 2019 10:21
@hangie
Add link in demo
bd2a420
@hangie
Symlinks not working consistently on windows - remove
e10f2e6
@hangie
Add query import/export
6ab13a2
@hangie
Change plain SQL query extension to .sql
e2a571e
@hangie
Fix error in export for sql
5ae6f74
@hangie
Switch menu to standard images
f95894f
@hangie
Switch to using exportedUI for menus
f6bd7f2
@hangie
Update readme and add default vcs.cfg
89d60a3
@hangie
Link
dc7f503
@hangie
More readme
37a43b1
@hangie
Merge branch 'feature/template_tables' into develop
3c6f625
@hangie
Merge branch 'master' into feature/merge_master
6d8c096 
Possible conflict on VCS_ImportExport as my changes override much of what was there.  Will examine manually next.
@hangie
Add default VERSION.txt if it doesn't exist
114428e
@hangie
Minor date to readme and changelog
55ba73f
@hangie
Merge branch 'feature/merge_master' into develop
82b325e
@hangie
Add VCS loader.
f759b57 
Still need to manually load VCS_Loader.  After that the button calls loadVCS.
@hangie
Copy link
Author

hangie commented Mar 21, 2019

This fixes #84, #83, #79, #50, #61

@hangie
Copy link
Author

hangie commented Mar 22, 2019

Fixes #85, #57.

@timabell
Copy link
Member

timabell commented Mar 25, 2019 •
edited
Loading

Nice work, thanks for the contribution. I'm afraid I'm going to be a bit picky, it's difficult to see in this PR what has been done as it has many commits and merges. If there are problems it'll be impossible to work out the source of an issue by looking at the history.

Please break this up into one PR per feature / bugfix, and make sure each one is based on timabell/master

Something like:

o  timabell/master
  \_ o _ o export-as-sql
  \_ o _ o fix-backslash-escaping

@hangie
Copy link
Author

hangie commented Mar 26, 2019 •
edited
Loading

This will be a bit of a challenge, but I'll do what I can.

Added need pull request to cover fix for previous changes in merge/hangie_develop.

Will follow this with other changes.

@hangie hangie closed this Mar 26, 2019
@timabell
Copy link
Member

#88

hecon5 pushed a commit to hecon5/msaccess-vcs-integration that referenced this pull request Jun 15, 2021
@joyfullservice @hecon5
Beginning work on translation support
8c58ba0 
Started building out functions for handling translation of strings. See msaccess-vcs-integration#87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hangie @timabell