Default filename backend extensions #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| a default filename. | ||
| """ | ||
| default_filename = self.get_window_title() or 'image' | ||
| default_filename = default_filename.lower().replace(' ', '_') |
There was a problem hiding this comment.
Do we really want to enforce lowercase filenames? Capitalization in the window title might be important.
There was a problem hiding this comment.
:-) I will remove it and highlight it in the mpl pull request for discussion.
|
Otherwise, looks good! Thanks! |
mspacek
added a commit
that referenced
this pull request
May 31, 2012
Default filename backend extensions
mspacek
pushed a commit
that referenced
this pull request
Jan 19, 2013
Add texinfo support to plot directive
mspacek
pushed a commit
that referenced
this pull request
Jan 19, 2013
Create the symlink without using chdir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to the matplotlib pull request matplotlib:#908