Thanks to visit codestin.com
Credit goes to github.com

Skip to content

APG 9.0.0 migration#14

Merged
mmathieum merged 4 commits intomasterfrom
mm/agp9
Feb 4, 2026
Merged

APG 9.0.0 migration#14
mmathieum merged 4 commits intomasterfrom
mm/agp9

Conversation

@mmathieum
Copy link
Member

@mmathieum mmathieum commented Jan 22, 2026 •
edited
Loading

@mmathieum mmathieum self-assigned this Jan 22, 2026
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 22, 2026

Summary of Changes

Hello @mmathieum, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the project's Gradle build configuration by migrating Kotlin compiler settings to the contemporary kotlin extension block. This update streamlines the build process, aligns with the latest Gradle Kotlin plugin recommendations, and prepares the project for potential future updates or migrations, as suggested by the 'APG 9.0.0 migration' title.

Highlights

  • Kotlin Build Configuration Update: The Gradle build file has been updated to use the modern kotlin { compilerOptions { ... } } syntax for configuring Kotlin compilation. This change replaces the older, deprecated compileKotlin and compileTestKotlin blocks, consolidating Kotlin compiler settings into a single, unified configuration.
  • Consolidated Compiler Options: The jvmTarget and allWarningsAsErrors settings for Kotlin compilation are now managed within the new kotlin.compilerOptions block, ensuring consistency and adherence to current best practices for Kotlin projects using Gradle.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 22, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the Kotlin compiler options configuration in build.gradle, likely as part of an upgrade to Android Gradle Plugin 9.0.0. The change correctly refactors the deprecated compileKotlin and compileTestKotlin blocks into a single, modern kotlin extension block. This simplifies the build script and aligns it with current best practices. My review includes one suggestion to remove a now-confusing comment to improve the maintainability of the build configuration.

@mmathieum mmathieum mentioned this pull request Jan 22, 2026
Merged
3 tasks
@mmathieum mmathieum mentioned this pull request Feb 3, 2026
Merged
mmathieum added a commit to mtransitapps/commons-android that referenced this pull request Feb 3, 2026
@mmathieum
APG 9.0.0 migration
6ee2bf6 
- mtransitapps/commons-java#14
- mtransitapps/commons#523
@mmathieum mmathieum mentioned this pull request Feb 3, 2026
Merged
@mmathieum mmathieum marked this pull request as ready for review February 3, 2026 21:42
@mmathieum mmathieum merged commit a7f30d0 into master Feb 4, 2026
7 of 8 checks passed
@mmathieum mmathieum deleted the mm/agp9 branch February 4, 2026 16:11
montransit added a commit to mtransitapps/mtransit-for-android that referenced this pull request Feb 4, 2026
@montransit
CI: Sync code from 'commons' & 'commons-android' & 'commons-java' & '…
63c9ca5 
…parser':

- commons: APG 9.0.0 migration mtransitapps/commons#523
- commons-android: APG 9.0.0 migration mtransitapps/commons-android#54
- commons-java: APG 9.0.0 migration mtransitapps/commons-java#14
- parser: APG 9.0.0 migration mtransitapps/parser#28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mmathieum mmathieum

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mmathieum