-
Notifications
You must be signed in to change notification settings - Fork 3
Schedule > clear head-sign instead of setting empty string #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 1e07710.
Summary of ChangesHello @mmathieum, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reintroduces a previously reverted change aimed at refining the management of head-signs within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request reverts a previous commit, primarily to restore the behavior of clearing head-signs in MSchedule when they are blank, instead of setting an empty string. This is a good change as it leads to a cleaner and more explicit state for schedules without a head-sign. The PR also includes some nice code quality improvements, such as removing an unused import, simplifying a conditional in GenerateMObjectsTask.java, and suppressing a linter warning for feature flags. The changes are well-justified and improve the codebase.
- parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
- commons: mt-sync-code-data.yml > fix skip on main repo - commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Fix compat with service IDs only used for data changed - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32
No description provided.