fix(gpu): better detection for MacOS and Thor#9263
Merged
Conversation
Signed-off-by: Ettore Di Giacinto <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds support for detecting Apple Silicon (M1/M2) GPUs and improves unified memory handling across platforms. It introduces logic to identify Apple GPUs on macOS, reports their memory usage as unified system RAM, and updates related utilities for vendor color mapping and device lists. Additionally, it improves detection of NVIDIA Jetson/Tegra devices with unified memory and updates a Go module dependency.
Apple Silicon (macOS) GPU support:
system_profileron macOS, reporting GPU memory as system RAM and returning unified memory usage for Apple GPUs. (pkg/xsysinfo/gpu.go) [1] [2] [3]VendorAppleconstant and updated vendor color mapping to include Apple. (pkg/xsysinfo/gpu.go,core/http/react-ui/src/utils/format.js) [1] [2]Unified memory device support:
pkg/xsysinfo/gpu.go)pkg/xsysinfo/gpu.go) [1] [2]Dependency updates:
github.com/mudler/memoryGo module to a newer version. (go.mod)Notes for Reviewers
Signed commits