Drop server port input, upgrade all libraries, port global database installs to docker #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…drop-server-port-input
Merged
…/datastation into pe/drop-server-port-input
…drop-server-port-input
b4a5064 to
0b54370
Compare
6f0ba71 to
1e7e5d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You could override the port in the server Address field but the Port field was ignored. Really there's no need for the Port field to be separate anyway so I'm just dropping it.
Closes #274
Additionally this PR:
integrationtest directory and the newwithDockerhelper helps schedule the docker image needed for each test. All database tests have been ported.