Fix double sided not syncing false #4481
Open
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some objects are double sided by default, so SetDoubleSided must be called for them if you want it to be false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some objects are double sided by default, so SetDoubleSided must be called for them if you want it to be false.
Fixes: multitheftauto/mtasa-resources#230
To reproduce:
start editor
Add object 3851
Make sure doublesided = false
Save the map
Open the map
Notice it now says doublesided = true
crun isElementDoubledSided(getElementsByType("object")[1]) -- returns true
srun isElementDoubledSided(getElementsByType("object")[1]) -- returns false
PR fixes this desync. I guess this object is doublesided by default, and the object sync would only set true, never false.