Fix MSVC compiler warnings #30897
Open
Fix MSVC compiler warnings #30897
+18
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
commented
Nov 6, 2025
Jojo-Schmitz
commented
Nov 6, 2025
Open
714ad12 to
6639280
Compare
reg.: 'return': conversion from 'size_t' to 'int', possible loss of data (C4267) Co-Authored-By: Casper Jeukendrup <[email protected]>
6639280 to
36e33bf
Compare
cbjeukendrup
reviewed
Nov 6, 2025
| } | ||
| if (tefMeasures.at(index).isPickup) { | ||
| auto offset { offsetInMeasure(position, tefMeasures) }; | ||
| if (0 <= index && 0 <= offset) { |
There was a problem hiding this comment.
Oh wait, now we've got a new one here... Looks like we just need to remove 0 <= index &&
(same below)
cbjeukendrup
reviewed
Nov 6, 2025
| auto index { measureIndex(tstart, tefMeasures) }; | ||
| if (0 <= index) { | ||
| return tstart - nominalMeasureStarts.at(index); | ||
| size_t index{ measureIndex(tstart, tefMeasures) }; |
There was a problem hiding this comment.
whitespace damage, or was it uncrustify?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.