schema: add stem.split to att.stems#1310
Open
rettinghaus wants to merge 3 commits into
Open
Conversation
riedde
previously approved these changes
Jan 18, 2024
Contributor
riedde
left a comment
There was a problem hiding this comment.
Reviewed and tested at the MEI Developer Workshop 2024
musicEnfanthen
requested changes
Jan 20, 2024
Member
musicEnfanthen
left a comment
There was a problem hiding this comment.
Can you please add a short example and explanation in the guidelines for this use case.
Co-authored-by: Stefan Münnich <[email protected]>
Member
|
as mentioned above please add a corresponding example to the guidelines, thx. |
Member
|
Still needs work, moving to 6 |
Contributor
|
Hi @rettinghaus. I think this only needs guidelines examples, and it will be done. Do you think you can include these examples by the next ODD Meeting (March 27th)? That would be great as we can merge it right away (either during or before the meeting). Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems we reached consensus on possible encodings for split stem notation.
This PR offers an implementation with
@stem.splitas part ofatt.stems.Alternatively it could be a direct child of
noteto simplify the schematron rules.closes #721