Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add support for platform version range#111

Merged
mxcl merged 6 commits intomxcl:masterfrom
bamx23:os-version
Sep 11, 2024
Merged

Add support for platform version range#111
mxcl merged 6 commits intomxcl:masterfrom
bamx23:os-version

Conversation

@bamx23
Copy link
Contributor

@bamx23 bamx23 commented Sep 8, 2024

Allows specifying the version (a range of versions) of the target simulator.

@mxcl
Copy link
Owner

mxcl commented Sep 8, 2024

I'm fixing CI currently

@mxcl
Copy link
Owner

mxcl commented Sep 9, 2024

If you rebase and rebuild the dist files it CI is working again.

@bamx23
Copy link
Contributor Author

bamx23 commented Sep 10, 2024

Thanks @mxcl, all rebased and CI passes now. Yet I'm not sure that the check I've added was run.

@mxcl
Copy link
Owner

mxcl commented Sep 10, 2024

It was not run because you did not use the matrix value os-version in the job.

I would also request os-version be renamed platform-version to match the platform key.

@bamx23
Copy link
Contributor Author

bamx23 commented Sep 11, 2024

Good catch about the use in job, fixed. And also renamed to platform-version.

@bamx23 bamx23 changed the title Add support for OS version range Add support for platform version range Sep 11, 2024
@mxcl mxcl merged commit 22c08b0 into mxcl:master Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants