Open
Conversation
Collaborator
Author
|
I just realized that I allocate an extra vector for each function even if it doesn't use type comments, but an alternative would be ugly (because of per-argument comments support), so I propose to think about optimizing this later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1
Implementation is relatively straightforward, although I don't handle all edge cases yet. I manually checked this fixes few dozen tests in mypy. Couple notes:
parse()on the original function type comment just to get the token stream and split comment into argument types and return type..clone()calls on the parsed comments. I am not a Rust performance expert, but it looks like this is inevitable since we need to mutate them (relocate to meaningful locations, so that they can be used as context for type errors in mypy).