Conversation
Agent-Logs-Url: https://github.com/n3crosis/opencode/sessions/49f38d9c-2304-442d-afb8-6159375148d5 Co-authored-by: n3crosis <[email protected]>
Agent-Logs-Url: https://github.com/n3crosis/opencode/sessions/49f38d9c-2304-442d-afb8-6159375148d5 Co-authored-by: n3crosis <[email protected]>
Agent-Logs-Url: https://github.com/n3crosis/opencode/sessions/49f38d9c-2304-442d-afb8-6159375148d5 Co-authored-by: n3crosis <[email protected]>
Agent-Logs-Url: https://github.com/n3crosis/opencode/sessions/49f38d9c-2304-442d-afb8-6159375148d5 Co-authored-by: n3crosis <[email protected]>
Copilot created this pull request from a session on behalf of
n3crosis
May 15, 2026 06:25
View session
n3crosis
marked this pull request as ready for review
May 17, 2026 10:43
There was a problem hiding this comment.
Pull request overview
This PR updates web startup authentication so Basic credentials embedded in the page URL are parsed into the initial HTTP server connection while keeping the server URL credential-free.
Changes:
- Adds
authFromUrlfor parsing Basic auth userinfo from URLs. - Allows empty-string passwords to still generate Basic Authorization headers.
- Adds focused tests for URL credential parsing cases.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/app/src/utils/server.ts |
Adds URL auth parsing and changes SDK auth header generation for empty passwords. |
packages/app/src/utils/server.test.ts |
Adds coverage for parsing credentials from URLs. |
packages/app/src/entry.tsx |
Wires URL-derived credentials into the startup server connection. |
Comments suppressed due to low confidence (1)
packages/app/src/utils/server.ts:42
- The changed behavior that sends Basic auth when
passwordis an empty string is not covered by the existing server utility tests. Add coverage forcreateSdkForServer(or equivalent request construction) so username-only credentials continue to produce an Authorization header instead of regressing to the old falsy-password behavior.
if (server.password === undefined) return undefined
return {
Authorization: `Basic ${authTokenFromCredentials({ username: server.username, password: server.password })}`,
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (root instanceof HTMLElement) { | ||
| const auth = authFromToken(new URLSearchParams(location.search).get("auth_token")) | ||
| const auth = authFromToken(new URLSearchParams(location.search).get("auth_token")) ?? authFromUrl(location.href) | ||
| clearAuthToken() |
| if (!url.username && url.password === "") return undefined | ||
| return { | ||
| username: url.username ? decodeURIComponent(url.username) : "opencode", | ||
| password: url.password ? decodeURIComponent(url.password) : "", |
Owner
|
@copilot sync to the latest branch and modify the pull request according to contribution md again |
…sync-error Co-authored-by: n3crosis <[email protected]>
Agent-Logs-Url: https://github.com/n3crosis/opencode/sessions/6f06909d-b09d-43ce-85ca-20f0912e0fd7 Co-authored-by: n3crosis <[email protected]>
Agent-Logs-Url: https://github.com/n3crosis/opencode/sessions/6f06909d-b09d-43ce-85ca-20f0912e0fd7 Co-authored-by: n3crosis <[email protected]>
Agent-Logs-Url: https://github.com/n3crosis/opencode/sessions/6f06909d-b09d-43ce-85ca-20f0912e0fd7 Co-authored-by: n3crosis <[email protected]>
Author
Synced the branch with latest Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
Fix web basic auth startup credentials
fix(app): handle web basic auth startup credentials
May 17, 2026
2 tasks
Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: rekram1-node <[email protected]>
…ger requires matching explicit requirements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Type of change
What does this PR do?
When the web app is opened with HTTP Basic credentials in the URL, the app reads those credentials into the startup server connection while continuing to use a credential-free server URL. This lets SDK requests include the expected Basic Authorization header and avoids startup failures around the global sync provider.
The app now also removes startup credentials from the browser URL/history after extracting them, and terminal WebSocket fallback auth treats an empty password as valid Basic Auth instead of omitting auth.
Added focused coverage for parsing credentials from URLs and terminal auth token handling.
How did you verify your code works?
oxlint packages/app/src/entry.tsx packages/app/src/utils/server.ts packages/app/src/utils/server.test.ts packages/app/src/utils/terminal-websocket-url.ts packages/app/src/utils/terminal-websocket-url.test.tsbun typecheck, but it is blocked because dependency install failed andtsgois unavailable.@happy-dom/global-registratoris unavailable.bun install --frozen-lockfile, but GitHub returned 403 foranomalyco/ghostty-web.Screenshots / recordings
N/A
Checklist
If you do not follow this template your PR will be automatically rejected.