Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Restrict eventlet#501

Merged
mattbennett merged 3 commits into
masterfrom
restrict-eventlet
Jan 12, 2018
Merged

Restrict eventlet#501
mattbennett merged 3 commits into
masterfrom
restrict-eventlet

Conversation

@mattbennett

Copy link
Copy Markdown
Member

No description provided.

@davidszotten

Copy link
Copy Markdown
Member

does 6aa00da only affect travis?

@mattbennett

Copy link
Copy Markdown
Member Author

6aa00da will apply if you run your tests locally using tox as well.

@davidszotten

Copy link
Copy Markdown
Member

so that fix is now out, but we can't use it because the http is broken instead?

@davidszotten

Copy link
Copy Markdown
Member

not sure i understand the reason for the tox change

@mattbennett

Copy link
Copy Markdown
Member Author

Yes :(

I've had some discussion about the breaking change in eventlet/eventlet#420 but honestly got a bit lost with it.

@mattbennett

Copy link
Copy Markdown
Member Author

The tox change is required because we were no longer actually testing against eventlet master. See https://travis-ci.org/nameko/nameko/builds/328005814?utm_source=github_status&utm_medium=notification

Before the change tox was executing the following commands:

pip install --upgrade https://github.com/eventlet/eventlet/archive/master.zip (from mastereventlet match)
pip install --editable .[dev] (from lib match)
make test_lib (from lib match)

pip install --editable .[dev] after pip install ...master.zip was pulling eventlet back down to the pinned version

@mattbennett mattbennett merged commit fb7560e into master Jan 12, 2018
@mattbennett mattbennett deleted the restrict-eventlet branch January 12, 2018 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants