Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add dependency workaround for Intel-based Macs #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 8, 2025
Merged

Add dependency workaround for Intel-based Macs #227

merged 9 commits into from
Jun 8, 2025

Conversation

lymichelle21
Copy link
Contributor

@lymichelle21 lymichelle21 commented May 14, 2025 •
edited
Loading

NOTE: This is a backup option in case the transition from tensorflow to PyTorch doesn't work

tensorflow is needed to enable data-driven features in Progpy. However, we need a dependency workaround using an older version of tensorflow at 2.16.2 since newer versions like 2.18.0 are not available for Intel-based Macs. Older versions of tensorflow may have issues with newer versions of numpy and numpoly.

The workaround thus includes a know working combination of of tensorflow==2.16.2, numpy==1.26.4, and numpoly==1.2.12.

More information on tensorflow support, refer to tensorflow/tensorflow#78836

@lymichelle21 lymichelle21 added the bug Something isn't working label May 14, 2025
@github-actions GitHub Actions
Copy link

Thank you for opening this PR. Since this is a release branch, the PR must complete the release checklist, below:

  • Check that each new feature has corresponding tests

  • Confirm all dependencies are in the following: requirements.txt, setup.py, the bottom of dev_guide.rst

  • Confirm that all issues associated with the release have been closed (i.e., requirements have been met) or assigned to another release

  • Run unit tests python -m tests, on

    • Windows

    • Linux

    • Apple Silicon Mac

    • Intel Mac

  • If present, run manual tests python -m tests.test_manual

  • Review the template(s)

  • Review static-analysis/linter results

  • Review the tutorial

  • Run and review the examples

  • Check that all examples are tested

  • Check new files in PR for any accidentally added

  • Check documents

    • Check that all desired examples are in docs

    • General review: see if any updates are required

  • Rebuild sphinx documents: sphinx-build sphinx_config/ docs/

  • Write release notes

  • Update version number in src/*/init.py and setup.py

  • For releases adding new features- ensure that NASA release process has been followed.

  • Confirm that on GitHub Releases page, the next release has been started and that a schedule is present including at least Release Date, Release Review Date, and Release Branch Opening Date.`

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/v1.8@fbce739). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff               @@
##             release/v1.8     #227   +/-   ##
===============================================
  Coverage                ?   83.69%           
===============================================
  Files                   ?      103           
  Lines                   ?    10961           
  Branches                ?        0           
===============================================
  Hits                    ?     9174           
  Misses                  ?     1787           
  Partials                ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lymichelle21 lymichelle21 marked this pull request as ready for review May 16, 2025 17:23
@lymichelle21 lymichelle21 force-pushed the manual-release-test branch from ba9fedb to be447d0 Compare May 16, 2025 17:26
@lymichelle21 lymichelle21 requested review from kjjarvis and teubert May 16, 2025 17:27
@teubert teubert merged commit 83df376 into release/v1.8 Jun 8, 2025
64 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teubert teubert teubert approved these changes

@kjjarvis kjjarvis Awaiting requested review from kjjarvis

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lymichelle21 @codecov-commenter @teubert