feat: adds dataAttributes to linkPressTargetToOnDOMLinkPressArgs in plugins-core #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lugins-core formidable-webview/webshell has added dataAttributes to LinkPressTarget in September 2021. [1] This commit adds it to linkPressTargetToOnDOMLinkPressArgs so that data attributes on achor tags are available in onPress-handlers. [1] formidable-webview/webshell@0a2c3e0
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
=======================================
Coverage 91.44% 91.44%
=======================================
Files 14 14
Lines 304 304
Branches 95 95
=======================================
Hits 278 278
Misses 26 26
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jsamr
approved these changes
Jan 9, 2023
|
Thanks for this! |
|
@jsamr Are you planning to release this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
formidable-webview/webshell has added dataAttributes to LinkPressTarget in September 2021. [1]
This commit adds it to linkPressTargetToOnDOMLinkPressArgs so that data attributes on anchor tags are available in onPress-handlers.
[1] formidable-webview/webshell@0a2c3e0