Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactor defaultProps to default parameters #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor defaultProps to default parameters #49

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbba152
Refactor defaultProps to default parameters
DanielKuhn Sep 4, 2024
88f1d56
Remove propTypes
DanielKuhn Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Refactor defaultProps to default parameters
  • Loading branch information
@DanielKuhn
DanielKuhn committed Sep 4, 2024
commit cbba152f9cc3b666f11fc9ae962747b8c49dce97
18 changes: 3 additions & 15 deletions packages/table-plugin/src/HTMLTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,15 +259,15 @@ export const HTMLTable = function HTMLTable({
cssRules,
html,
sourceBaseUrl,
animationType,
animationType = 'animated',
computeHeuristicContentHeight = defaultComputeHeuristicContentHeight,
computeContainerHeight = defaultComputeContainerHeight,
webViewProps: userWebViewProps,
style,
onLinkPress,
animationDuration,
animationDuration = DEFAULT_TRANSITION_DURATION,
htmlAttribs,
maxScale,
maxScale = 1,
...stats
}: HTMLTableProps) {
const onDOMLinkPress = useCallback(
Expand Down Expand Up @@ -331,18 +331,6 @@ const propTypes: Record<keyof HTMLTableProps, any> = {
displayMode: PropTypes.oneOf(['flex', 'expand'])
};

const defaultProps = {
animationDuration: DEFAULT_TRANSITION_DURATION,
animationType: 'animated',
computeHeuristicContentHeight: defaultComputeHeuristicContentHeight,
computeContainerHeight: defaultComputeContainerHeight,
maxScale: 1
};

Object.defineProperty(HTMLTable, 'propTypes', {
value: propTypes
});

Object.defineProperty(HTMLTable, 'defaultProps', {
value: defaultProps
});
2 changes: 1 addition & 1 deletion packages/table-plugin/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ export interface TableConfig {
*
* @defaultValue 1
*/
maxScale?: boolean;
maxScale?: number;

/**
* Container style.
Expand Down