fix(auth): make --device-auth login work end-to-end - #478

Summary

• Fix --device-auth crash from "Detected unsettled top-level await" by adding a keepAlive option to the device-auth flow that prevents polling timers from being unref'd in CLI context.
• Skip the Accounts Dashboard menu when an explicit transport flag (--device-auth, --manual, --no-browser) is provided, so the requested mode runs even with existing accounts.
• Exit cleanly after declining "Add another?" when an explicit transport mode was used (previously looped back into a fresh sign-in).

Closes #477

Files Changed

• lib/auth/device-auth.ts adds opt-in keepAlive plumbing in getSleep and sleepWithAbort. Default behavior preserved for library consumers.
• lib/codex-manager.ts passes keepAlive: true from the single CLI call site, gates the dashboard with explicitSignInMode, and returns 0 from the add-another decline branch when in explicit mode.
• test/device-auth.test.ts adds 3 unit tests for the keepAlive plumbing.
• test/codex-manager-cli.test.ts adds 2 integration tests for dashboard bypass with existing accounts (one for --device-auth, one for --manual).

Risk Notes

• keepAlive defaults to false, so existing library consumers of runDeviceAuthFlow keep the previous unref'd-timer behavior.
• Dashboard skip only triggers when the user explicitly passes a transport flag. Bare cx auth login with existing accounts still opens the dashboard.
• Manage-account refresh, repair commands, and interactive promptOAuthSignInMode were audited: none reach runDeviceAuthFlow so keepAlive exposure is contained to the documented CLI entry point.
• AbortSignal path was checked: when keepAlive: true and the signal aborts, clearTimeout runs before reject, so the ref is released and the process can exit.

Test plan

• npm run typecheck clean
• npm test 3979/3979 passing across 267 files in 112s
• Local manual verification: codex-multi-auth login --device-auth prints device code, stays alive past the previous crash point, completes auth, and exits cleanly after n to "Add another?"
• Local manual verification with existing account pool: cx auth login --device-auth bypasses the dashboard and runs device-auth directly

note: greptile review for oc-chatgpt-multi-auth. cite files like lib/foo.ts:123. confirm regression tests + windows concurrency/token redaction coverage.

Greptile Summary

this pr fixes --device-auth login end-to-end by adding a keepAlive option that prevents polling timers from being unref'd in the cli context, skipping the accounts dashboard when an explicit transport flag is passed, and returning cleanly from all three exit edges (cancel, add-another decline, max-accounts cap).

• lib/auth/device-auth.ts adds keepAlive?: boolean to DeviceAuthFlowOptions; both getSleep and sleepWithAbort gate unrefTimer behind !options.keepAlive, with the abort path correctly calling clearTimeout before rejecting to release the handle.
• lib/codex-manager.ts sets keepAlive: true at the single cli call site, derives explicitSignInMode from loginOptions.deviceAuth || loginOptions.manual (which correctly covers --no-browser since that flag maps to manual: true in parseAuthLoginArgs), and guards all three inner-loop exit edges with if (explicitSignInMode) return 0 — including the previously unguarded MAX_ACCOUNTS break.
• five new integration/unit tests cover keepAlive timer behaviour, dashboard bypass for --device-auth and --manual, clean cancel exit, and the max-accounts cap branch.

Confidence Score: 5/5

safe to merge — the change is self-contained, defaults are preserved for library consumers, and all three inner-loop exit edges in explicit mode are correctly guarded.

keepAlive defaults to false, so no existing library consumer behaviour changes. the explicitSignInMode guard is derived correctly from parsed options (covering --no-browser via loginOptions.manual). the previously unguarded MAX_ACCOUNTS break is fixed in this diff and covered by a new integration test. the abort path clears the referenced timer before rejecting, so no process-hang risk. no concurrency or windows filesystem concerns introduced.

no files require special attention.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["cx auth login [--device-auth | --manual | --no-browser]"] --> B{explicitSignInMode?}
    B -- yes --> D[skip dashboard]
    B -- no --> C{existing accounts?}
    C -- yes --> E[show accounts dashboard]
    E --> F{menu result}
    F -- add --> D
    F -- cancel --> Z[return 0]
    D --> G[runSignInFlow]
    G -- device --> H["runDeviceAuthFlow(keepAlive: true)"]
    G -- manual/browser --> I[runOAuthFlow]
    H --> J{result}
    I --> J
    J -- cancelled & explicitSignInMode --> Z
    J -- success --> K[persistAccountPool]
    K --> L{count >= MAX_ACCOUNTS?}
    L -- yes & explicitSignInMode --> Z
    L -- yes & !explicit --> M[break → loginFlow restart]
    L -- no --> N[promptAddAnotherAccount]
    N -- false & explicitSignInMode --> Z
    N -- false & !explicit --> M
    N -- true --> G

_{Reviews (3): Last reviewed commit: "fix(auth): exit cleanly at MAX_ACCOUNTS ..." | Re-trigger Greptile}