test: cover login-menu data layer targeting, view model, and drift sync - #563

Summary

Fourth suite in the direct-coverage push for the login machinery (siblings: #559, #560, #561; all independent, based on main). lib/codex-manager/login-menu-data.ts had direct tests only for refreshQuotaCacheForMenu; its other three exports — the quota probe targeting, the dashboard view model, and the Codex CLI drift sync — were exercised only through the interactive menu. This adds test/login-menu-data.test.ts (15 tests).

countMenuQuotaRefreshTargets and toExistingAccountInfo run with no mocks at all (pure given storage/cache/settings fixtures); only loadCodexCliState and setCodexCliActiveSelection are mocked for the drift-sync tests.

What the tests pin

countMenuQuotaRefreshTargets (decides which accounts the menu probes):

• Counts enabled accounts with usable tokens and stale/missing cache entries.
• Skips disabled accounts, tokens inside the 5-minute freshness window, and cache entries younger than the TTL.
• Skips accounts whose probe result could not be stored behind a safe lookup key (duplicate accountIds with no email fallback) — probing them would waste requests on unattributable snapshots.

toExistingAccountInfo (the dashboard row view model):

• Status mapping: active (current row), disabled, cooldown, quota-exhausted (0% remaining with a future reset), rate-limited (429 entry), and plain ok.
• Ready-first ordering: most quota headroom first, exhausted accounts last; index becomes the display position while sourceIndex still points into storage; isDefaultAccount survives reordering.
• Quick-switch numbering in both modes: visible-row (default) and storage-position (menuSortQuickSwitchVisibleRow: false).
• Source order preserved when sorting is disabled.

syncCodexCliActiveSelectionIfDrifted (repairs auth.json drift):

• No-ops when the CLI state matches by accountId, when there is no CLI state, when the match is by sanitized email (case/whitespace-insensitive) with accountIds absent, when the state read throws, and for an empty pool (no read at all).
• On real drift, rewrites the CLI selection with exactly the active account's credentials and reports the writer's result. Also pins the { forceRefresh: true } read.

Validation

• vitest run test/login-menu-data.test.ts — 15/15 passing
• npm run typecheck — clean
• npx eslint test/login-menu-data.test.ts --max-warnings=0 — clean

https://claude.ai/code/session_01XNtnkLbBiXZxfQQYLMpucB

Generated by Claude Code

note: greptile review for oc-chatgpt-multi-auth. cite files like lib/foo.ts:123. confirm regression tests + windows concurrency/token redaction coverage.

Greptile Summary

adds test/login-menu-data.test.ts, providing direct vitest coverage for four of the five exports in lib/codex-manager/login-menu-data.ts. the previous review feedback was addressed in this revision: both the writer-false propagation path and the loadRuntimeCurrentSelectionForStorage describe block are now included.

• countMenuQuotaRefreshTargets (5 tests): verifies disabled-account skipping, token-freshness window, stale-cache counting, and the duplicate-accountId / no-email-fallback safety gate that prevents unattributable probe snapshots.
• toExistingAccountInfo (4 tests): pins status mapping for all six states, ready-first sort + display/storage index renumbering, quick-switch numbering in both visible-row and storage-position modes, and sort-disabled source-order preservation.
• syncCodexCliActiveSelectionIfDrifted (7 tests): covers match-by-id no-op, null-state no-op, accountId drift rewrite, writer-false propagation (windows EBUSY path), sanitized-email match, read-throws no-op, and empty-pool early exit.
• loadRuntimeCurrentSelectionForStorage (3 tests): verifies all three runtime signals are threaded to the resolver, app-bind null-passthrough when router is not running, and Promise.all error swallowing to null for both signal sources.

Confidence Score: 5/5

test-only addition with no production code changes; safe to merge

the suite is a pure test addition with no changes to production code. all assertions were verified against the source: status ordering, index/sourceIndex renumbering, quick-switch numbering, drift-sync branching, and the Promise.all error-swallowing paths all match the implementation. both concerns from the previous review round are addressed — the writer-false propagation test and the loadRuntimeCurrentSelectionForStorage describe block are present.

no files require special attention

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[syncCodexCliActiveSelectionIfDrifted] --> B{activeIndex valid\nand accounts non-empty?}
    B -- no --> C[return false]
    B -- yes --> D[loadCodexCliState\nforceRefresh: true]
    D -- throws --> C
    D -- null --> C
    D -- state --> E{accountId present\non both sides?}
    E -- yes --> F{accountIds match?}
    F -- yes --> C
    F -- no --> I[setCodexCliActiveSelection\nwith active account creds]
    E -- no --> G{emails present\non both sides?}
    G -- yes --> H{sanitized emails match?}
    H -- yes --> C
    H -- no --> I
    G -- no --> I
    I --> J[return writer result\ntrue = written, false = skipped/EBUSY]

_{Reviews (2): Last reviewed commit: "test: cover runtime selection loading an..." | Re-trigger Greptile}