docs: refresh the lib knowledge-base tree for the extraction era - #589
Conversation
The §4.1 extractions and companion fixes added module clusters the curated STRUCTURE tree never picked up: codex-manager/formatters/, request/helpers/ + rate-limit-decision + stream-failover-runtime, the runtime rotation-* helpers, policy/, fs-retry, temp-path, budget-guard, and local-bridge. Adds them in tree style, points WHERE TO LOOK at the shared retry and temp-path helpers, and names the CodexError hierarchy in the errors.ts row. https://claude.ai/code/session_01XNtnkLbBiXZxfQQYLMpucB
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Warning Review limit reached
More reviews will be available in 4 minutes and 7 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
docs: list login-menu-accounts beside its login-menu siblings
Summary
lib/AGENTS.md's curated STRUCTURE tree never picked up the module clusters the §4.1 extraction era created, so a reader following it today misses several load-bearing seams.What Changed
codex-manager/formatters/(shared CLI text/account/model/quota formatters),policy/, therequest/sub-entries (helpers/,rate-limit-decision.ts,stream-failover-runtime.ts), theruntime/rotation-*.tsextraction cluster (selection/state/storage-meta/server-type helpers), plus four top-level modules:fs-retry.ts(the sharedwithRetry/withRetrySynchome from §4.2),temp-path.ts(the crypto-random staging-path helper from audit H1),budget-guard.ts, andlocal-bridge.ts.fs-retry.ts(every retry loop declares its policy there as of refactor: migrate the last two hand-rolled retry loops to withRetry #585) and "Temp/staging paths" →temp-path.ts(with the never-Math.random()reminder from H1).errors.tsrow now names theCodexErrorhierarchy, matching the typed-error contracts shipped in refactor: throw CodexValidationError from rotation-proxy startup guards #586/refactor: abort unreadable config saves with a typed StorageError #587.└── ...ellipses), mirroring how docs: refresh test knowledge-base counts and list the new suites #588 handled the test knowledge bases.Validation
npm run typecheck(pre-commit hook)npm test -- test/documentation.test.ts— passesmainnpm test/npm run build— not run for this markdown-only changeDocs and Governance Checklist
Risk and Rollback
https://claude.ai/code/session_01XNtnkLbBiXZxfQQYLMpucB
Generated by Claude Code
note: greptile review for oc-chatgpt-multi-auth. cite files like
lib/foo.ts:123. confirm regression tests + windows concurrency/token redaction coverage.Greptile Summary
refreshes
lib/AGENTS.mdto reflect the module layout created during the §4.1 extraction era. all added paths have been verified to exist onmain.codex-manager/formatters/,policy/,request/sub-entries, andruntime/rotation-*.ts(all five helpers includingtoken-refresh), plus four new top-level entries:fs-retry.ts,temp-path.ts,budget-guard.ts,local-bridge.ts.fs-retry.tsand "temp/staging paths" →temp-path.ts;errors.tsdescription is updated to name theCodexErrorhierarchy.Confidence Score: 5/5
markdown-only change; every added path verified to exist on main; no runtime behavior touched.
all documented paths exist, rotation-*.ts now covers all five helpers including token-refresh, and withRetry/withRetrySync exports match the WHERE TO LOOK entry. no code changed.
no files require special attention.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD LIB[lib/] --> CM[codex-manager/] LIB --> POL[policy/] LIB --> REQ[request/] LIB --> RT[runtime/] LIB --> TOP[top-level modules] CM --> FMT[formatters/ ← NEW\ntext/account/model/quota] CM --> SCMD[commands/] POL --> RPT[runtime-policy.ts ← NEW] REQ --> HLP[helpers/ ← NEW\nmodel-map, input/tool utils] REQ --> RLD[rate-limit-decision.ts ← NEW] REQ --> SFR[stream-failover-runtime.ts ← NEW] RT --> ROT[rotation-*.ts ← NEW\nselection/state/storage-meta\nserver-type/token-refresh] TOP --> FSR[fs-retry.ts ← NEW\nwithRetry / withRetrySync] TOP --> TMP[temp-path.ts ← NEW\ncrypto-random staging paths] TOP --> BGD[budget-guard.ts ← NEW] TOP --> LBR[local-bridge.ts ← NEW] TOP --> ERR[errors.ts\nCodexError hierarchy]Reviews (2): Last reviewed commit: "docs: include token-refresh in the rotat..." | Re-trigger Greptile
Context used: