Update 543-Diameter-of-Binary-Tree.py #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original `return -1` and `2+` actually cancel each other out and thus serve no purpose.
|
@MeViMo nice! What do you think about changing the res variable from a # Definition for a binary tree node.
# class TreeNode:
# def __init__(self, val=0, left=None, right=None):
# self.val = val
# self.left = left
# self.right = right
class Solution:
def diameterOfBinaryTree(self, root: Optional[TreeNode]) -> int:
res = 0
def dfs(root: Optional[TreeNode]):
nonlocal res
if not root:
return 0
left = dfs(root.left)
right = dfs(root.right)
res = max(res, left + right)
return 1 + max(left, right)
dfs(root)
return res |
|
@anandbaburajan That's probably what I would do to. You can push that change to this PR if you like. Up to the maintainers whether or not to include it. |
|
I can push the changes but I think you need to resolve the conflicts first. |
|
I don't need to but I did for your convenience. |
whitespace is annoying
Nowhere else in the repo are nested functions annotated so I guess we don't do it here either.
543-Diameter-of-Binary-Tree.py: Use nonlocal res instead of using a list
|
Thanks, @MeViMo and @anandbaburajan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original
return -1and2+actually cancel each other out and thus serve no purpose, only causing confusion.