[bugfix] Only use Vertex env vars when needed #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamillitman
commented
Jul 10, 2025
|
|
||
| //The URL requires GOOGLE_REGION and GOOGLE_PROJECT_ID env variables defined to work. | ||
| //If not set GOOGLE_REGION will default to 'us-central1' but GOOGLE_PROJECT_ID needs to be defined. | ||
| let vertex_url = format!( | ||
| "{}/{}:streamGenerateContent?alt=sse", | ||
| &*GOOGLE_VERTEX_API_URL, | ||
| self.as_str() | ||
| ); | ||
|
|
||
| let vertex_url_fine_tuned = format!( | ||
| "{}/{}:generateContent", | ||
| &*GOOGLE_VERTEX_ENDPOINT_API_URL, | ||
| self.as_str() | ||
| ); | ||
|
|
||
| match (self, version) { |
There was a problem hiding this comment.
Because of this code we were still using the Vertex env vars even if they are never needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.