feat: split platform arg by the last = #5994
Open
+52
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the parsing of the -P/--platform flag to consider the last = instead of the first. Point being = is a valid character for a runs-on definition but its not for docker images. taking the last = should be a good enough heuristic while still being backward compatible. fixes nektos#4691
better warn message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the parsing of the -P/--platform flag to consider the last = instead of the first.
Point being
=is a valid character for a runs-on definition but it's not for docker images. Splitting the -P flag at the last=should be a good enough heuristic to support equal character while still being backward compatible.Fixes #4691