Flush S/MIME passkey on failure to sign #4679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using classic S/MIME (i.e., via OpenSSL commands instead of using GPGMe), NeoMutt caches the private key passphrase. However, it fails to flush the cache on a failure to sign, which presumably comes from the user entering a wrong passphrase. So, upon entering a wrong passphrase, the user currently has to wait for the cache to expire (`smime_timeout`) before trying again. This PR fixes it, by immediately flusing the cached passphrase upon failure to sign.
flatcap
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using classic S/MIME (i.e., via OpenSSL commands instead of using GPGMe), NeoMutt caches the private key passphrase. However, it fails to flush the cache on a failure to sign, which presumably comes from the user entering a wrong passphrase.
So, upon entering a wrong passphrase, the user currently has to wait for the cache to expire (
smime_timeout) before trying again.This PR fixes it, by immediately flusing the cached passphrase upon failure to sign.