expunge: guard against segfault #4697
Merged
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, calling imap_edata_get() can return NULL, if the corresponding edata field is NULL. Don't segfault in this case.
5586ac9 to
572a8a6
Compare
flatcap
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, calling imap_edata_get() can return NULL, if the corresponding edata field is NULL.
Don't segfault in this case.
What I cannot determine here, is why the call to
imap_edata_get()hasedata == NULLand I can't track that down. That would be the preferred fix here, but since this issue comes up once in a blue moon, I thought I'd post this here to indicate the issue...