Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[RFC]vim-patch:8.2.0295: highlighting for :s wrong when using different separator #14286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
janlazo merged 1 commit into from
Apr 4, 2021
Merged

[RFC]vim-patch:8.2.0295: highlighting for :s wrong when using different separator #14286

janlazo merged 1 commit into from
Apr 4, 2021

Conversation

@glacambre
Copy link
Member

@glacambre glacambre commented Apr 4, 2021

No description provided.

@glacambre glacambre force-pushed the vim-8.2.0295 branch 2 times, most recently from f0d8139 to 5beda9d Compare April 4, 2021 11:25
@janlazo
Copy link
Contributor

janlazo commented Apr 4, 2021

@glacambre Can you verify if there are later patches that improve or fix this patch?

janlazo
janlazo reviewed Apr 4, 2021
View reviewed changes
janlazo
janlazo reviewed Apr 4, 2021
View reviewed changes
@janlazo janlazo changed the title vim-patch:8.2.0295: highlighting for :s wrong when using different separator [WIP]vim-patch:8.2.0295: highlighting for :s wrong when using different separator Apr 4, 2021
@janlazo janlazo added this to the 0.5.1 milestone Apr 4, 2021
@janlazo janlazo added the vim-patch See https://neovim.io/doc/user/dev_vimpatch.html label Apr 4, 2021
glacambre
glacambre commented Apr 4, 2021
View reviewed changes
Copy link
Member Author

@glacambre glacambre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing my PR :).

AFAICS, there aren't any other patches related to this bug.

@glacambre
Copy link
Member Author

glacambre commented Apr 4, 2021

I think I might have missed yet another hunk. Please wait before merging this.

@glacambre
vim-patch:8.2.0295: highlighting for :s wrong when using different se…
4dab338 
…parator

Problem:    Highlighting for :s wrong when using different separator.
Solution:   Use separat argument for search direction and separator. (Rob
            Pilling, closes vim/vim#5665)
vim/vim@c036e87
@glacambre
Copy link
Member Author

glacambre commented Apr 4, 2021

Yes, I had botched the application of one hunk. Things should be hopefully ok now.

@glacambre glacambre changed the title [WIP]vim-patch:8.2.0295: highlighting for :s wrong when using different separator [RFC]vim-patch:8.2.0295: highlighting for :s wrong when using different separator Apr 4, 2021
@janlazo janlazo merged commit 0f18770 into neovim:master Apr 4, 2021
@glacambre glacambre deleted the vim-8.2.0295 branch April 5, 2021 09:53
@janlazo janlazo modified the milestones: 0.5.1, 0.5 Apr 20, 2021
@janlazo janlazo mentioned this pull request Jun 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@janlazo janlazo janlazo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

vim-patch See https://neovim.io/doc/user/dev_vimpatch.html

Projects

None yet

Milestone

0.5

Development

Successfully merging this pull request may close these issues.

2 participants

@glacambre @janlazo