Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(signs): change b_signcols_max -> b_signcols_valid #14391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2021
Merged

refactor(signs): change b_signcols_max -> b_signcols_valid #14391

merged 1 commit into from
Jul 4, 2021

Conversation

lewis6991
Copy link
Member

@lewis6991 lewis6991 commented Apr 18, 2021 •
edited
Loading

b_signcols_max isn't used to store the max value, it is just used to invalidate b_signcols.

@lewis6991
Copy link
Member Author

@janlazo , @bfredl : Sorry to nudge but anything wrong with this?

@janlazo
Copy link
Contributor

janlazo commented Jul 4, 2021

b_signcols_max came from #9295 so it's safe to refactor independent of vim patches. The change itself is safe.

@bfredl
Copy link
Member

bfredl commented Jul 4, 2021

@lewis6991 should be fine but please rebase to master :]

@lewis6991
signs: Change b_signcols_max -> b_signcols_valid
65b0918 
b_signcols_max isn't used to store the max value, it is use to
invalidate b_signcols.
@bfredl bfredl merged commit c6226bd into neovim:master Jul 4, 2021
@lewis6991 lewis6991 deleted the signs branch July 4, 2021 21:17
@clason clason changed the title signs: Change b_signcols_max -> b_signcols_valid refactor(signs): change b_signcols_max -> b_signcols_valid Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lewis6991 @janlazo @bfredl