fix(float): fix ghost cmdline on down-scroll #35667
Open
+29
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
a ghost cmdline appears when scrolling a full-height float window downward
Solution:
Change
bot - MAX(rows, 0)
tobot - 1
to correctly check if the float grid is being covered by msg_gridwill fix #34512
Additional notes:
bot - 1
could also correctly detect ifdefault_grid
is covered bymsg_grid
whenlaststatus=0
, this avoids triggering arecompose
:v0.11.3.mp4
this-pr.mp4
bot - MAX(rows, 0)
is introduced in PR #11025, and I also add a test case for its related issue #11019.attrbuf[i] > 0
, so I feel the condition code below might be outdated. If we want to remove the code later, the test case might be useful.neovim/src/nvim/ui_compositor.c
Lines 679 to 686 in 1cb1cfe
This is the 4th issue I dug into. I picked up a lot of low-level concepts while debugging last week, but there might still be gaps in my understanding. Please feel free to point out anything if I'm wrong. :)