Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(ex_cmds): improve E77 glob expansion message#39843

Open
puneetdixit200 wants to merge 5 commits into
neovim:masterfrom
puneetdixit200:fix/e77-glob-expansion-message
Open

fix(ex_cmds): improve E77 glob expansion message#39843
puneetdixit200 wants to merge 5 commits into
neovim:masterfrom
puneetdixit200:fix/e77-glob-expansion-message

Conversation

@puneetdixit200
Copy link
Copy Markdown
Contributor

@puneetdixit200 puneetdixit200 commented May 18, 2026

Summary

  • Clarify E77 as a single-file-name limit without making it glob-specific.
  • Update help text for explicit or glob-expanded multiple file names and point glob users to :next.
  • Add a functional test for :edit with a glob argument.

Closes #12139

Test

  • git diff --check

Copilot AI review requested due to automatic review settings May 18, 2026 00:38

This comment was marked as spam.

@superatomic superatomic added the AI assisted 🤖 May contain trace amounts of GMO label May 18, 2026
@superatomic
Copy link
Copy Markdown
Member

(see previous: #39829)

Please refrain from using copilot for future PRs; it's noisy. Just run copilot on your own machine.

Comment thread src/nvim/errors.h Outdated
Comment thread test/functional/ex_cmds/excmd_spec.lua Outdated
@puneetdixit200 puneetdixit200 force-pushed the fix/e77-glob-expansion-message branch from 0fe10fd to 2651bcf Compare May 18, 2026 15:34
puneetdixit200 and others added 3 commits May 20, 2026 15:36
Problem:
The E77 help text only described glob expansion, even though the error can also be raised by explicit multiple file names.

Solution:
Describe both explicit multiple names and glob expansion in the E77 help entry.

AI-assisted: Codex
Comment thread test/functional/ex_cmds/edit_spec.lua Outdated
Comment thread runtime/doc/message.txt Outdated

*E77* >
Too many file names
Too many file names (glob not allowed)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the (glob not allowed) misleading here since as explained just below, it doesn't necessarily implies a glob was used

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted this in 36e03ab: E77 now says "Too many file names (only one allowed)", and the doc text below keeps the glob-specific :next hint.

Copy link
Copy Markdown
Member

@justinmk justinmk May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are going in circles. this was already settled in #12139

the minor risk of "misleading" is outweighed by the UX improvement for other cases

@puneetdixit200
Copy link
Copy Markdown
Contributor Author

I checked the current failed Windows functional run. The changed ex_cmds group, including test/functional/ex_cmds/edit_spec.lua, passed on Windows. The failure happened later in unrelated plugin, treesitter, ui, vimscript, and terminal groups with Nvim processes exiting unexpectedly (0xc0000142 / EOF from Nvim).

I tried to rerun the failed job, but GitHub rejected the rerun with Must have admin rights to Repository. I do not see a branch-local patch indicated by this failure.

@justinmk justinmk added the needs:response Waiting for reply, will auto-close after 30 days. label May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI assisted 🤖 May contain trace amounts of GMO needs:response Waiting for reply, will auto-close after 30 days.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UX: ":edit *.js" should suggest :next

5 participants