fix: Enhance multisig handling for optional since value #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
XuJiandong
commented
Mar 20, 2025
- Update the C implementation to conditionally check the lock period logic based on the presence of a since value.
- Add a new test case to verify multisig unlocking behavior without a since value.
* Update the C implementation to conditionally check the lock period logic based on the presence of a since value. * Add a new test case to verify multisig unlocking behavior without a since value.
xxuejie
reviewed
Mar 20, 2025
xxuejie
approved these changes
Mar 20, 2025
|
deployed on testnet:
|
zhangsoledad
approved these changes
Apr 17, 2025
|
deployed on mainnet:
|
This was referenced Apr 18, 2025
This was referenced Jun 7, 2025
XuJiandong
added a commit
to XuJiandong/ckb-script-error-codes
that referenced
this pull request
Jun 16, 2025
doitian
pushed a commit
to nervosnetwork/ckb-script-error-codes
that referenced
this pull request
Jun 19, 2025
* feat: add new multisig error codes nervosnetwork/ckb-system-scripts#99 (comment) * chore: not use link * docs: update version link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.