Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: add lighthouse ci check #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 15, 2020
Merged

chore: add lighthouse ci check #1211

merged 4 commits into from
Jun 15, 2020

Conversation

BrunnerLivio
Copy link
Member

@BrunnerLivio BrunnerLivio commented May 1, 2020 •
edited
Loading

Resolves #971

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@BrunnerLivio BrunnerLivio mentioned this pull request May 1, 2020
Closed
1 task
@BrunnerLivio BrunnerLivio force-pushed the feature/lighthouse-ci branch 8 times, most recently from 57ba05b to 365790c Compare May 2, 2020 00:23
BrunnerLivio
BrunnerLivio commented May 2, 2020
View reviewed changes
@BrunnerLivio
Copy link
Member Author

BrunnerLivio commented May 2, 2020 •
edited
Loading

We can definitely improve in the Lighthouse scores! Though I think it makes more sense to create issues for each of them individually :)

(I think it is a bit lower than when you run it on your machine because of Network latency in Github Actions)
Selection_110

FYI: You will find the report inside the logs

@kamilmysliwiec
Copy link
Member

Love it ❤️

I've just merged #1212 so I guess we can lower the "sleep" step a little bit

@BrunnerLivio BrunnerLivio force-pushed the feature/lighthouse-ci branch 7 times, most recently from 82c76d8 to e0b7235 Compare May 23, 2020 21:27
@BrunnerLivio BrunnerLivio force-pushed the feature/lighthouse-ci branch from e0b7235 to a0129a8 Compare May 23, 2020 21:38
BrunnerLivio
BrunnerLivio commented May 23, 2020
View reviewed changes
BrunnerLivio
BrunnerLivio commented May 23, 2020
View reviewed changes
@kamilmysliwiec
Copy link
Member

BTW it seems that the Lighthouse / build (push) step is failing now (in this PR :D)

@BrunnerLivio
Copy link
Member Author

BrunnerLivio commented Jun 14, 2020 •
edited
Loading

@kamilmysliwiec
Should be resolved now. I quickly tested it as well on my fork.

BrunnerLivio#1: Pull request with only markdown changes (does not run Lighthouse)

BrunnerLivio#2: Pull request with CSS changes (does run lighthouse)

Submitted a PR to JakePartusch/wait-for-netlify-action#9 so we can get rid of the sleep as well :)

@kamilmysliwiec
Copy link
Member

Thank you @BrunnerLivio 💪

@kamilmysliwiec kamilmysliwiec merged commit 04c2609 into master Jun 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/lighthouse-ci branch June 15, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilmysliwiec kamilmysliwiec kamilmysliwiec left review comments

Assignees
No one assigned
Labels
feature status: wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Lighthouse check in CI
2 participants
@BrunnerLivio @kamilmysliwiec