Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(docs): remove hardcoded ".ts" suffix from main file reference in trust proxy example #3252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

Pedroo-Nietoo
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

Fix incorrect filename extension in "trust proxy" example under Security > Rate Limiting
The example hardcodes the ".ts" suffix when referencing the "main" file, resulting in incorrect filenames like "main.ts.ts" or "main.ts.js". This commit removes the fixed suffix to ensure correct file resolution based on the context.

Issue Number: N/A

What is the new behavior?

The updated example now aligns with the behavior of other code examples in the documentation by dynamically adjusting the filename between ".js" and ".ts", depending on the context. This prevents incorrect filenames like "main.ts.ts" or "main.ts.js" and ensures consistency across the documentation.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec kamilmysliwiec merged commit 1167e54 into nestjs:master Apr 24, 2025
4 checks passed
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants