fix MSI installer #19962
Merged
fix MSI installer #19962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
…ry key listed (FileInUse)
ilyam8
reviewed
Mar 27, 2025
|
This pull request has been mentioned on Netdata Community Forums. There might be relevant details there: |
This comment was marked as resolved.
This comment was marked as resolved.
ilyam8
approved these changes
Mar 27, 2025
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Mar 28, 2025
* allow users to install any version; stop netdata before installing the update * fix compatibility with wix 4 * fix-msi: Remove conflict between options (https://docs.firegiant.com/wix3/xsd/wix/majorupgrade/) * fix-msi: Comment not allowed code. We cannot have more than one primary key listed (FileInUse) * fix-msi: Add Power Shell script to be called after installation * fix-msi: Copy power shell script to installer. * fix-msi: Add option to do download and move PS file * fix-msi: First try run at the end * iis_ad: Fix wrong execution order and call to powershell * fix-msi: Add messages and test to Power Shell script --------- Co-authored-by: thiagoftsm <[email protected]> (cherry picked from commit e80fdfd)
Merged
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Mar 28, 2025
* allow users to install any version; stop netdata before installing the update * fix compatibility with wix 4 * fix-msi: Remove conflict between options (https://docs.firegiant.com/wix3/xsd/wix/majorupgrade/) * fix-msi: Comment not allowed code. We cannot have more than one primary key listed (FileInUse) * fix-msi: Add Power Shell script to be called after installation * fix-msi: Copy power shell script to installer. * fix-msi: Add option to do download and move PS file * fix-msi: First try run at the end * iis_ad: Fix wrong execution order and call to powershell * fix-msi: Add messages and test to Power Shell script --------- Co-authored-by: thiagoftsm <[email protected]> (cherry picked from commit e80fdfd)
Ferroin
pushed a commit
that referenced
this pull request
Apr 2, 2025
* allow users to install any version; stop netdata before installing the update * fix compatibility with wix 4 * fix-msi: Remove conflict between options (https://docs.firegiant.com/wix3/xsd/wix/majorupgrade/) * fix-msi: Comment not allowed code. We cannot have more than one primary key listed (FileInUse) * fix-msi: Add Power Shell script to be called after installation * fix-msi: Copy power shell script to installer. * fix-msi: Add option to do download and move PS file * fix-msi: First try run at the end * iis_ad: Fix wrong execution order and call to powershell * fix-msi: Add messages and test to Power Shell script --------- Co-authored-by: thiagoftsm <[email protected]> (cherry picked from commit e80fdfd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development
stream.conftoetc/netdatanetdata.conffrom the running netdata, if it is not already there.netdata.conffails, create an emptynetdata.conf, but only if it is not already thereTest Plan