fix(go.d/megacli): handle BBU hardware component is not present #20008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #20005 by modifying the megacli collector to handle cases where the BBU hardware component is not present. The changes introduce a new flag in the Collector struct to control BBU data collection and update the collection logic to disable BBU collection on error.
- Added a new boolean flag (doBBU) in the Collector to toggle BBU collection.
- Modified the collect function to disable BBU collection if an error occurs.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/go/plugin/go.d/collector/megacli/collector.go | Added the doBBU flag in both the constructor and the struct definition to enable conditional BBU collection. |
| src/go/plugin/go.d/collector/megacli/collect.go | Updated the collection logic to conditionally attempt BBU collection and disable it upon failure. |
Comments suppressed due to low confidence (1)
src/go/plugin/go.d/collector/megacli/collector.go:41
- [nitpick] Consider renaming 'doBBU' to 'enableBBU' to more clearly indicate that this flag controls whether BBU collection is enabled.
doBBU: true,
stelfrag
approved these changes
Mar 31, 2025
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Mar 31, 2025
…ata#20008) (cherry picked from commit fd97fd9)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Apr 2, 2025
(cherry picked from commit fd97fd9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #20005
Test Plan
Additional Information
For users: How does this change affect me?