Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Additional checks then creating a v2 journal file #20018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

stelfrag
Copy link
Collaborator

@stelfrag stelfrag commented Apr 1, 2025

Summary
  • Simplify file creation when building a v2 journal file
    • Use ftruncate instead of lseek / write / ftruncate
    • Make sure file is closed on fruncate failure
    • Verify size after ftruncate

@stelfrag stelfrag marked this pull request as ready for review April 1, 2025 07:21
@stelfrag stelfrag changed the title Addition checks then creating a v2 journal file Additional checks then creating a v2 journal file Apr 1, 2025
@ktsaou ktsaou merged commit 543aa59 into netdata:master Apr 1, 2025
102 of 103 checks passed
@stelfrag stelfrag deleted the adjust_memory_file_open branch April 1, 2025 10:02
@stelfrag stelfrag mentioned this pull request Apr 1, 2025
stelfrag added a commit to stelfrag/netdata that referenced this pull request Apr 1, 2025
Simplify memory_file_open

(cherry picked from commit 543aa59)
Ferroin pushed a commit that referenced this pull request Apr 2, 2025
Simplify memory_file_open

(cherry picked from commit 543aa59)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants