SNMP Collector, use custom YAML files for auto single metrics #20020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ilyam8 I got the tests passing, but I could not get the Failing ones to make sense, I pass the normal expect, and it works, couldn't figure out what was going on. If we need more test cases let me know so I can add them, do we need a case where there is user config metrics, but no auto YAML device discovered, for example? |
ilyam8
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@ilyam8 I removed the further functionality I had added, but because I touched the go.mod file for that custom package and ran go mod tidy, there are changes to both go.mod and go.sum. Please check
I also removed some code regarding tables (which Netdata can't now support) and removed also code for tags, as that is also something I understand that at the moment we can't support.
Let me know of any further changes we need here.