Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix MSSQL and improvements #20032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Apr 17, 2025
Merged

Fix MSSQL and improvements #20032

merged 33 commits into from
Apr 17, 2025

Conversation

thiagoftsm
Copy link
Contributor

@thiagoftsm thiagoftsm commented Apr 2, 2025

Summary

Partially fix #19629.
Partially fix #19818.

This PR addresses different issues in our MSSQL pluigin. It adds the basis for we go ahead fixing the remaining issues.

dbFIleSize

Test Plan
  1. Follow documentation and configure instance(s) of MSSQL
  2. Compile this branch.
  3. Create an installer.
  4. Install netdata.
Additional Information

This PR was tested on the following scenarios:

Host Instances Options
Windows 11 2 Only one configured
Windows 11 2 Without configuration
Windows 11 2 Two instances configured
Windows 2019 1 One instance configured
Windows 2019 1 One instance, without additional configuration
For users: How does this change affect me?

@thiagoftsm thiagoftsm marked this pull request as draft April 2, 2025 12:00
@github-actions github-actions bot added area/docs area/collectors Everything related to data collection area/build Build system (autotools and cmake). collectors/windows labels Apr 2, 2025
@thiagoftsm thiagoftsm force-pushed the fix_mssql branch 3 times, most recently from 95f1ead to cdada65 Compare April 10, 2025 17:15
@thiagoftsm thiagoftsm force-pushed the fix_mssql branch 4 times, most recently from 8bfeab7 to 4b22462 Compare April 15, 2025 20:18
@thiagoftsm thiagoftsm marked this pull request as ready for review April 17, 2025 04:27
@thiagoftsm thiagoftsm requested a review from stelfrag April 17, 2025 04:27
@thiagoftsm thiagoftsm merged commit aff8890 into netdata:master Apr 17, 2025
102 of 103 checks passed
stelfrag pushed a commit to stelfrag/netdata that referenced this pull request Apr 28, 2025
@stelfrag stelfrag mentioned this pull request Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build system (autotools and cmake). area/collectors Everything related to data collection area/docs collectors/windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: MSSQL Data not being correctly monitored [Feat]: Log data via MSSQL Query
2 participants