Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Locks (Windows Locks) #20131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 16, 2025
Merged

Fix Locks (Windows Locks) #20131

merged 8 commits into from
Apr 16, 2025

Conversation

thiagoftsm
Copy link
Contributor

Summary

Fix issue:

# 7 rrdset_done [0x1006CE246] (/src/database/rrdset-collection.c:507)
#8 do_mssql_locks [0x100548CA0] (/src/collectors/windows.plugin/perflib-mssql.c:892)
#9 dict_mssql_charts_cb [0x100534C17] (/src/collectors/windows.plugin/perflib-mssql.c:1422)
#10 dictionary_sorted_walkthrough_rw [0x100537EAA] (/src/libnetdata/dictionary/dictionary-traversal.c:247)
#11 do_PerflibMSSQL [0x10053D71C] (/src/collectors/windows.plugin/perflib-mssql.c:1439)
#12 win_plugin_main [0x1007BB961] (/src/collectors/windows.plugin/windows_plugin.c:196)
#13 nd_thread_starting_point [0x1005F7DD0] (/src/libnetdata/threads/threads.c:362)
Test Plan
  1. Check CI
  2. Compile build locally
  3. Make an installer.
  4. Install on host running MSSQL Server.
Additional Information
For users: How does this change affect me?

@github-actions github-actions bot added area/collectors Everything related to data collection collectors/windows labels Apr 15, 2025
@thiagoftsm thiagoftsm marked this pull request as draft April 15, 2025 18:35
@thiagoftsm thiagoftsm changed the title Fix Locks Fix Locks (Windows Locks) Apr 15, 2025
@thiagoftsm thiagoftsm marked this pull request as ready for review April 15, 2025 20:01
@ilyam8 ilyam8 merged commit 26fe27e into netdata:master Apr 16, 2025
103 checks passed
@thiagoftsm thiagoftsm deleted the mssql_locks branch April 16, 2025 12:02
stelfrag pushed a commit to stelfrag/netdata that referenced this pull request Apr 28, 2025
@thiagoftsm @stelfrag
Fix Locks (Windows Locks) (netdata#20131)
532351c 
(cherry picked from commit 26fe27e)
@stelfrag stelfrag mentioned this pull request Apr 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktsaou ktsaou ktsaou approved these changes

@stelfrag stelfrag stelfrag approved these changes

@ilyam8 ilyam8 Awaiting requested review from ilyam8

Assignees
No one assigned
Labels
area/collectors Everything related to data collection collectors/windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thiagoftsm @ktsaou @stelfrag @ilyam8