Outline buffer functions #20856
Open
Outline buffer functions #20856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inlining everything bloats our binary size. Outlining just the buffer functions reduces binary size by half. Before this change: FILE SIZE VM SIZE -------------- -------------- 75.0% 9.92Mi 70.8% 9.92Mi .text 0.0% 0 5.6% 802Ki .bss 4.8% 656Ki 4.6% 656Ki .eh_frame 4.1% 553Ki 3.9% 552Ki .data 3.9% 525Ki 3.7% 525Ki .dynstr 3.7% 494Ki 3.4% 494Ki .rodata.str1.1 1.8% 240Ki 1.7% 240Ki .dynsym 1.7% 233Ki 1.6% 233Ki .rela.dyn 1.2% 159Ki 1.1% 159Ki .rodata 1.0% 131Ki 0.9% 131Ki .gcc_except_table 0.9% 126Ki 0.9% 126Ki .eh_frame_hdr 0.6% 77.9Ki 0.5% 74.5Ki .data.rel.ro 0.4% 58.3Ki 0.4% 58.2Ki .gnu.hash 0.3% 40.0Ki 0.3% 39.9Ki .rodata.str1.8 0.2% 22.8Ki 0.2% 22.8Ki protodesc_cold 0.1% 20.1Ki 0.1% 20.0Ki .gnu.version 0.1% 11.2Ki 0.1% 14.9Ki [30 Others] 0.1% 14.6Ki 0.1% 14.5Ki .rela.plt 0.1% 9.78Ki 0.1% 9.72Ki .plt 0.0% 4.93Ki 0.0% 4.87Ki .got.plt 0.0% 4.00Ki 0.0% 3.94Ki .tdata 100.0% 13.2Mi 100.0% 14.0Mi TOTAL After: FILE SIZE VM SIZE -------------- -------------- 60.3% 4.86Mi 55.0% 4.86Mi .text 0.0% 0 8.9% 802Ki .bss 7.8% 641Ki 7.1% 641Ki .eh_frame 6.7% 553Ki 6.1% 552Ki .data 6.4% 527Ki 5.8% 527Ki .dynstr 6.0% 494Ki 5.5% 494Ki .rodata.str1.1 2.9% 242Ki 2.7% 242Ki .dynsym 2.8% 233Ki 2.6% 233Ki .rela.dyn 1.5% 127Ki 1.4% 127Ki .eh_frame_hdr 1.4% 115Ki 1.3% 115Ki .gcc_except_table 0.9% 77.8Ki 0.8% 74.5Ki .data.rel.ro 0.9% 71.7Ki 0.8% 71.7Ki .rodata 0.7% 58.6Ki 0.6% 58.6Ki .gnu.hash 0.5% 40.0Ki 0.4% 39.9Ki .rodata.str1.8 0.3% 22.8Ki 0.3% 22.8Ki protodesc_cold 0.2% 20.3Ki 0.2% 20.2Ki .gnu.version 0.2% 14.6Ki 0.2% 14.5Ki .rela.plt 0.1% 11.3Ki 0.1% 13.1Ki [30 Others] 0.1% 9.78Ki 0.1% 9.72Ki .plt 0.1% 4.93Ki 0.1% 4.87Ki .got.plt 0.0% 4.00Ki 0.0% 3.94Ki .tdata 100.0% 8.05Mi 100.0% 8.83Mi TOTAL
|
@ktsaou If you want to inline a function do so after measuring the performance difference. Inlining everything defeats the purpose because you'll end up trashing the instruction cache. |
thiagoftsm
reviewed
Aug 20, 2025
| *e = '\0'; | ||
| return e - dst; | ||
| } | ||
|
|
There was a problem hiding this comment.
A minor, I have observed some additional unnecessary space between functions.
thiagoftsm
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inlining everything bloats our binary size. Outlining just the buffer functions reduces binary size by half.
Before this change:
After: