-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Win plugin files with .plugin extension #21068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
So while this allows plugins without .exe, this a) makes it harder to run it manually in debug mode, b) results in a mix of plugins with and without .exe? |
Microsoft requires a specific format and name, which is why the problem persists. To resolve this, we must deploy all binaries on Microsoft Windows with the .exe extension. Update: This is what Windows is expecting: Common file name extension |
thiagoftsm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even viewer is showing logs proofing collector is running. LGTM!
(cherry picked from commit 05b2bdd)
(cherry picked from commit 05b2bdd)
How? Have you tried it?
|
That's great then.
We regularly ask people to run plugins in debug mode to get more detailed logs for support requests. Why wouldn't that apply to Windows users? |
What plugins are we talking about? Are there multiple ones? I think there's only one. And it's usually used for debugging data collection jobs. Using dyncfg is a simpler and faster approach. Do we really ask win users to use terminal to debug data collection jobs? |
|
@ilyam8 , We were talking about missing extension addressed by this PR:
|
I will check for other plugins that may be missing file extensions and will ensure all of them have the appropriate extensions when compiled on Microsoft Windows. |

Summary