Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@stelfrag
Copy link
Collaborator

Summary
  • Allow .plugin extention

@stelfrag stelfrag marked this pull request as ready for review September 29, 2025 12:43
@stelfrag stelfrag requested a review from Ferroin as a code owner September 29, 2025 12:43
@stelfrag stelfrag requested a review from thiagoftsm September 29, 2025 12:43
@ralphm
Copy link
Member

ralphm commented Sep 29, 2025

So while this allows plugins without .exe, this a) makes it harder to run it manually in debug mode, b) results in a mix of plugins with and without .exe?

@thiagoftsm
Copy link
Contributor

thiagoftsm commented Sep 29, 2025

So while this allows plugins without .exe, this a) makes it harder to run it manually in debug mode, b) results in a mix of plugins with and without .exe?

Microsoft requires a specific format and name, which is why the problem persists. To resolve this, we must deploy all binaries on Microsoft Windows with the .exe extension.

Update: This is what Windows is expecting: Common file name extension

Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even viewer is showing logs proofing collector is running. LGTM!

@stelfrag stelfrag merged commit 05b2bdd into netdata:master Sep 29, 2025
107 checks passed
@stelfrag stelfrag deleted the win-plugin-ext branch September 29, 2025 14:16
stelfrag added a commit to stelfrag/netdata that referenced this pull request Sep 29, 2025
@stelfrag stelfrag mentioned this pull request Sep 29, 2025
Ferroin pushed a commit that referenced this pull request Sep 29, 2025
@ilyam8
Copy link
Member

ilyam8 commented Sep 29, 2025

@ralphm

a) makes it harder to run it manually in debug mode,

How? Have you tried it?

  • I didn't have any problems running it in the debug mode. I used the Command Prompt app.
  • Win users don't really need to run go.d.plugin in the debug mode because they can use dyncfg.

@ralphm
Copy link
Member

ralphm commented Sep 29, 2025

@ralphm

a) makes it harder to run it manually in debug mode,

How? Have you tried it?

  • I didn't have any problems running it in the debug mode. I used the Command Prompt app.

That's great then.

  • Win users don't really need to run go.d.plugin in the debug mode because they can use dyncfg.

We regularly ask people to run plugins in debug mode to get more detailed logs for support requests. Why wouldn't that apply to Windows users?

@ilyam8
Copy link
Member

ilyam8 commented Sep 29, 2025

We regularly ask people to run plugins in debug mode

What plugins are we talking about? Are there multiple ones? I think there's only one. And it's usually used for debugging data collection jobs. Using dyncfg is a simpler and faster approach. Do we really ask win users to use terminal to debug data collection jobs?

@thiagoftsm
Copy link
Contributor

@ilyam8 ,

We were talking about missing extension addressed by this PR:

Screenshot 2025-09-29 203609

@thiagoftsm
Copy link
Contributor

So while this allows plugins without .exe, this a) makes it harder to run it manually in debug mode, b) results in a mix of plugins with and without .exe?

I will check for other plugins that may be missing file extensions and will ensure all of them have the appropriate extensions when compiled on Microsoft Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants