Correctly split MCP registry update to it’s own workflow.#21089
Merged
Ferroin merged 2 commits intonetdata:masterfrom Oct 3, 2025
Merged
Correctly split MCP registry update to it’s own workflow.#21089Ferroin merged 2 commits intonetdata:masterfrom
Ferroin merged 2 commits intonetdata:masterfrom
Conversation
This needs to trigger when your releases are actually published, not when we start the release process, so it needs to have it’s own workflow with a release trigger instead of being part of the release workflow (as we always manually publish the release on GitHub). This actually simplifies a couple of parts of the job as well, since the `release` event defaults to using the commit of the release that triggered the workflow when checking out the repository.
3c295d7 to
f31cf94
Compare
Member
Author
|
Rebased to remove a commit that was erroneously made in the wrong branch. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR splits the MCP registry update functionality into its own dedicated workflow that triggers on actual releases rather than during the release process. This ensures the registry is updated only when releases are published on GitHub, not when the release process starts.
Key changes:
- Created a new standalone workflow file for MCP registry updates
- Changed trigger from being part of release workflow to using
releaseevent - Simplified version handling by reading from
packaging/versionfile instead of passing between jobs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/update-mcp-registry.yml |
New dedicated workflow for MCP registry updates triggered on release events |
.github/workflows/release.yml |
Removed the MCP registry publishing job from the existing release workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ilyam8
approved these changes
Oct 2, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Oct 27, 2025
) * Correctly split MCP registry update to it’s own workflow. This needs to trigger when your releases are actually published, not when we start the release process, so it needs to have it’s own workflow with a release trigger instead of being part of the release workflow (as we always manually publish the release on GitHub). This actually simplifies a couple of parts of the job as well, since the `release` event defaults to using the commit of the release that triggered the workflow when checking out the repository. * Address review comments. (cherry picked from commit 81acfc8)
Merged
Ferroin
added a commit
that referenced
this pull request
Oct 28, 2025
* Correctly split MCP registry update to it’s own workflow. This needs to trigger when your releases are actually published, not when we start the release process, so it needs to have it’s own workflow with a release trigger instead of being part of the release workflow (as we always manually publish the release on GitHub). This actually simplifies a couple of parts of the job as well, since the `release` event defaults to using the commit of the release that triggered the workflow when checking out the repository. * Address review comments. (cherry picked from commit 81acfc8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This needs to trigger when your releases are actually published, not when we start the release process, so it needs to have it’s own workflow with a release trigger instead of being part of the release workflow (as we always manually publish the release on GitHub).
This actually simplifies a couple of parts of the job as well, since the
releaseevent defaults to using the commit of the release that triggered the workflow when checking out the repository.Test Plan
n/a