Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Skip status file on windows on crash #21140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stelfrag merged 1 commit into from
Oct 13, 2025
Merged

Skip status file on windows on crash #21140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/daemon/status-file.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1495,6 +1495,11 @@ bool daemon_status_file_deadly_signal_received(EXIT_REASON reason, SIGNAL_CODE c
}

#ifdef HAVE_LIBBACKTRACE
#if defined(OS_WINDOWS)
// THE FOLLOWING CODE IS NOT ASYNC-SIGNAL-SAFE on MSYS2 due to internal locking in the runtime.
// This can cause a deadlock when a signal is received while the lock is held.
// The code is commented out to prevent the deadlock, at the cost of not saving the status file on a crash.
#else
bool safe_to_get_stack_trace = reason != EXIT_REASON_SIGABRT || stacktrace_capture_is_async_signal_safe();
bool get_stack_trace = stacktrace_available() && safe_to_get_stack_trace && stack_trace_is_empty(&session_status);

Expand All @@ -1509,7 +1514,8 @@ bool daemon_status_file_deadly_signal_received(EXIT_REASON reason, SIGNAL_CODE c

daemon_status_file_save(static_save_buffer, &session_status, false);
}
#endif
#endif // defined(OS_WINDOWS)
#endif // HAVE_LIBBACKTRACE

return duplicate;
}
Expand Down
Loading