Otel #21145
Otel #21145
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the OpenTelemetry plugin documentation by expanding configuration details, adding troubleshooting guidance, and restructuring the map.csv hierarchy. The changes provide comprehensive setup instructions for metrics and logs ingestion via OTLP/gRPC.
Key Changes:
- Added detailed documentation for metrics and logs configuration, including rotation/retention policies
- Included protocol support clarification (gRPC only) and SDK configuration examples
- Simplified map.csv hierarchy by removing nested "OpenTelemetry" category
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/crates/jf/otel-plugin/README.md | Comprehensive rewrite with new sections for protocol support, logs configuration, debugging, and SDK examples |
| docs/.map/map.csv | Added Windows installation entry and flattened OpenTelemetry category structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| instrumentation_scope_version: v0\.112\..* | ||
| # Match metric name (regex pattern, required) | ||
| metric_name: system\.network\.connections |
There was a problem hiding this comment.
The regex pattern escapes the dot in 'system.network' but the example on line 209 uses 'system\.network\.connections' without explaining why dots need escaping. Add a note explaining that dots must be escaped in regex patterns to match literal dots rather than any character.
There was a problem hiding this comment.
without explaining why dots need escaping
Because there is no explanation and no need.
how about we leave this unmerged until then? |
@vkalintiris hey, please check enhanced documentation + map.csv edit (currently initial otel page is empty, no reason for a clickdown)